Skip to content

test: fix TimeTest#8593

Merged
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:test-fix-TimeTest
Mar 5, 2024
Merged

test: fix TimeTest#8593
kenjis merged 2 commits intocodeigniter4:developfrom
kenjis:test-fix-TimeTest

Conversation

@kenjis
Copy link
Copy Markdown
Member

@kenjis kenjis commented Feb 29, 2024

Description

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

It is wrong to change the timezone only to setTestNow().
Remnants of the old code? Now UTC is the default timezone.
@kenjis kenjis added the testing Pull requests that changes tests only label Feb 29, 2024
@kenjis kenjis merged commit a99787c into codeigniter4:develop Mar 5, 2024
@kenjis kenjis deleted the test-fix-TimeTest branch March 5, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants